perf(store): skip db CacheKV in child CacheMultiStore creation
#2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## perf/stack-base #2838 +/- ##
====================================================
- Coverage 68.72% 56.80% -11.92%
====================================================
Files 5 2070 +2065
Lines 454 168450 +167996
====================================================
+ Hits 312 95688 +95376
- Misses 113 64269 +64156
- Partials 29 8493 +8464
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
When creating a child CMS via newCacheMultiStoreFromCMS (called from EVM Snapshot and OCC prepareTask), the db CacheKV was created but never accessed — all store access goes through module store keys. Build the child CMS directly instead of routing through NewFromKVStore, which eliminates: - The unused db CacheKV allocation (~10.7 GB / 30s in profiles) - One intermediate map copy (stores → storeParents) Also adds nil-safety for db in Write() since child CMS now has db=nil. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pdrobnjak
force-pushed
the
perf/optimize-updatereadset-alloc
branch
from
b97b114 to
de1b10e
Compare
pdrobnjak
force-pushed
the
perf/skip-db-cachekv-child-cms
branch
from
8b30fb3 to
8a05681
Compare
Base automatically changed from
perf/optimize-updatereadset-alloc
to
perf/hybrid-syncmap-rwmutex
February 11, 2026 13:19
Base automatically changed from
perf/hybrid-syncmap-rwmutex
to
perf/lazy-cachemultistore
February 11, 2026 13:19
pdrobnjak
changed the base branch from
perf/lazy-cachemultistore
to
perf/stack-base
pdrobnjak
changed the title
CacheMultiStore creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skip unnecessary db-backed CacheKV store creation when building child CacheMultiStore instances