[Revertible] Import autogenerated pydantic client#83
Open
phil-scale wants to merge 1 commit intolaunch-v1from
Open
[Revertible] Import autogenerated pydantic client#83phil-scale wants to merge 1 commit intolaunch-v1from
phil-scale wants to merge 1 commit intolaunch-v1from
Conversation
|
This pull request has been linked to Shortcut Story #710622: Launch python client overhaul. |
phil-scale
force-pushed
the
phil/autogen-pydantic-client
branch
from
91c0a20 to
388cf5e
Compare
Member
|
@phil-scale is there anything worth a human reviewing? Wasn't immediately obvious to me from a skim what was auto-generated vs. not. |
Contributor
Author
|
Yeah this is fully auto-generated. I'll keep it on this branch for now while I test it out (might be delayed due to LIRA). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the autogenerated pydantic clients from https://github.com/dmontagu/fastapi_client are much better than the OpenAPI autogenerated clients because 1) they provide async APIs 2) the serialization relies on Pydantic, which is faster and has more functionality than the OpenAPI auto-generated types.
This PR doesn't change the client to use these types because I think that's a bigger change that I'd like to separate into another PR.
[sc-710622]