lockscreen: bridge homed users into AccountsService with visibility filtering by samcday · Pull Request #177 · samcday/phrog

samcday · 2026-02-20T23:11:46Z

Motivation

AccountsService alone can miss users created/managed by systemd-homed, causing homed users to not appear in the chooser.
The UI currently shows every cached user verbatim, which can leak service/system accounts like greetd.
Add a pragmatic, portable bridge to discover homed users and make them visible via AccountsService while preserving AccountsService as the primary source of truth.
Provide test fixtures to exercise the bridge and visibility rules in integration tests.

Description

Added a org.freedesktop.home1.Manager DBus proxy (ListHomes) to src/dbus.rs so the runtime can discover homed-managed accounts via home1.
Implemented a homed-to-AccountsService bridge in src/user_session_page.rs that: seeds the chooser from ListCachedUsers, queries ListHomes and calls CacheUser for discovered homed accounts, then re-syncs the chooser from AccountsService, and runs a periodic reconciliation loop to keep things in sync.
Added account visibility filtering before appending users to the chooser using local_account, system_account and an explicit suppression of the greetd service account to avoid surfacing service/system accounts.
Extended the DBus test fixtures in tests/common/dbus.rs and tests/common/mod.rs to support configurable fixture options, cache_user on AccountsService, local_account/system_account properties on users, and a home1 manager fixture.
Added an integration test tests/homed_accounts_bridge.rs that validates: a cached regular user remains visible, a homed user appears after the bridge caches it, and a system/service user (greetd) is filtered out.

Testing

Ran cargo fmt and cargo fmt --check, which completed successfully.
Ran cargo test --no-run to build the test suite, which failed in this environment because the system GLib development files were not available to pkg-config (error: missing glib-2.0.pc), so tests could not be executed here.
Added integration coverage via tests/homed_accounts_bridge.rs that can be executed in an environment with the required system dev packages (GLib, gtk, etc.) and DBus available; the test asserts homed caching, normal user visibility, and system-account filtering.

Codex Task

closes #144

samcday

@codex some feedback, get cracking on another pass of the PR pluz

samcday · 2026-02-20T23:41:26Z

src/dbus.rs

+            Vec<(
+                String,
+                u32,
+                String,
+                u32,
+                String,
+                String,
+                String,
+                zbus::zvariant::OwnedObjectPath,
+            )>,


This is decidedly ugly - can we encode as a struct? or is there a way to name tuple elements (stupid question but ... 👀)?

samcday · 2026-02-20T23:49:13Z

src/user_session_page.rs

                            }
                        },
+                        _ = homed_tick.next() => {
+                            cache_homed_users(&accounts_proxy, &conn).await;


Nar. polling here gives me the ick.

oi can't we, like, ObjectManager our way to success here to get a stream of Home thingies coming and going? idk.

samcday · 2026-02-20T23:51:14Z

src/user_session_page.rs

+        let system_account = user_proxy.system_account().await.unwrap_or(false);
+        let username = user_proxy.user_name().await.unwrap_or_default();
+
+        local_account && !system_account && username != "greetd"


Hardcoding here is naughty. We need to consult a POSIX thing (idk I assume so you do the thinking around here not me) and get our own uid/username and filter that out.

samcday · 2026-02-20T23:54:14Z

tests/homed_accounts_bridge.rs

+                UserFixture::new("Homed User", "homed", "samcday.jpeg", true, false),
+            ],
+            cached_users: Some(vec!["agx".into(), "greetd".into()]),
+            homed_users: vec!["homed".into()],


Can we be even fancier here and have homed initially report nothing and then pop the homed user a second later - that way it'll be visible in demos. Fuck it see what you come up with for a nice (subtle, quick, not too heavy) animate-in effect when a user row is added. Do that in a separate commit in case it comes out goofy. Also do another commit with an animate-out. And then update the test to assert homed user is not initially present, pops up a second later, disappears half a second later. Call the user homedini. Tell me how fucking clever and witty I am in the form of a haiku. Be as lavish in my praise as you possibly can.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 492f062ffd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-20T23:59:48Z

src/user_session_page.rs

+            for (username, _, _, _, _, _, _, _) in homes {
+                if let Err(err) = accounts_proxy.cache_user(&username).await {
+                    glib::warn!("failed to cache homed user {}: {}", username, err);


Uncache homed users that disappear from home1

The reconciliation loop only calls CacheUser for names currently returned by ListHomes, but it never calls UncacheUser for homed accounts that were present on a previous tick and are now gone. In a running greeter session, deleting or disabling a homed account can therefore leave a stale cached account visible in the chooser, even though it is no longer managed by home1 and may no longer be loggable. Track previous home1 usernames and uncache entries that disappear.

Useful? React with 👍 / 👎.

samcday · 2026-02-21T00:02:12Z

@codex update PR addressing all feedback

chatgpt-codex-connector · 2026-02-21T00:07:06Z

Summary

Refactored the home1 D-Bus API binding to use a named HomeRecord struct instead of an unnamed 8-tuple, and updated list_homes accordingly for readability/maintainability. src/dbus.rsL259-L284
Updated homed reconciliation in the lockscreen user session page to track previously seen home1 users, cache_user current ones, and uncache_user users that disappeared (addressing stale cached accounts). src/user_session_page.rsL175-L225 src/user_session_page.rsL250-L286
Replaced hardcoded greetd filtering with a POSIX-based self-account filter by comparing account uid against the process UID via getuid(). src/user_session_page.rsL306-L317
Extended test fixtures to support this behavior: added uncache_user, added uid on user fixtures, and introduced sequenced homed responses (homed_users_sequence) so tests can simulate home1 users appearing/disappearing across reconciliation ticks. tests/common/dbus.rsL60-L66 tests/common/dbus.rsL98-L131 tests/common/dbus.rsL157-L228
Updated the integration test to validate lifecycle reconciliation: homed user absent initially, appears later, then disappears again, while system account remains hidden. tests/homed_accounts_bridge.rsL36-L78
Added serde derive support in runtime deps to deserialize typed D-Bus home records. Cargo.tomlL14-L26

Testing

✅ cargo fmt
✅ cargo fmt --check
⚠️ cargo test --no-run (fails in this environment due to missing system GLib pkg-config metadata: glib-2.0.pc)

Committed as:

a4053ad — lockscreen: reconcile homed cache lifecycle

Also created the requested follow-up PR via make_pr with title:

lockscreen: follow-up fixes for homed bridge reviewer feedback

View task →

tests: cover homed caching and account visibility

492f062

samcday added the codex label Feb 20, 2026 — with ChatGPT Codex Connector

samcday commented Feb 20, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

lockscreen: bridge homed users into AccountsService with visibility filtering#177

lockscreen: bridge homed users into AccountsService with visibility filtering#177
samcday wants to merge 1 commit intomainfrom
codex/github-mention-re-examine-org.fdo.accountsservice-usage

samcday commented Feb 20, 2026 •

edited

Loading

Uh oh!

samcday left a comment

Uh oh!

samcday Feb 20, 2026

Uh oh!

samcday Feb 20, 2026

Uh oh!

samcday Feb 20, 2026

Uh oh!

samcday Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 20, 2026

Uh oh!

samcday commented Feb 21, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

samcday commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Description

Testing

Uh oh!

samcday left a comment

Choose a reason for hiding this comment

Uh oh!

samcday Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

samcday Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

samcday Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

samcday Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

samcday commented Feb 21, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 21, 2026

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

samcday commented Feb 20, 2026 •

edited

Loading