fix: string formatting in display creation#527
Open
mdqst wants to merge 2 commits intosafe-global:mainfrom
Open
fix: string formatting in display creation#527mdqst wants to merge 2 commits intosafe-global:mainfrom
mdqst wants to merge 2 commits intosafe-global:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
falvaradorodriguez
previously approved these changes
Jul 8, 2025
It is necessary to check the tests first
Member
|
@mdqst Could you take a look at the tests? |
RamsesAupart
approved these changes
Jul 22, 2025
RamsesAupart
approved these changes
Jul 22, 2025
RamsesAupart
approved these changes
Jul 22, 2025
Author
all tests passed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i’ve updated the string formatting in the display creation line by replacing the old
%syntax with an f-string.this ensures the values are inserted correctly into the string and resolves any potential issues with formatting.