Skip to content

Fix LLVM intrinsic signatures for AVX-VNNI#2044

Merged
folkertdev merged 1 commit intorust-lang:mainfrom
sayantn:fix-signatures
Mar 4, 2026
Merged

Fix LLVM intrinsic signatures for AVX-VNNI#2044
folkertdev merged 1 commit intorust-lang:mainfrom
sayantn:fix-signatures

Conversation

@sayantn
Copy link
Contributor

@sayantn sayantn commented Mar 1, 2026

Context: LLVM changed these due to llvm/llvm-project#97271, and these will error when rust-lang/rust#140763 merges

r? @folkertdev

Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tough to actually validate. Did you test it with that branch to see that these are (all) the changes that are needed?

View changes since this review

@sayantn
Copy link
Contributor Author

sayantn commented Mar 4, 2026

yes, I did. Using a local build of rust-lang/rust#140763

edit: I tested only for x86, I can do aarch64 and riscv64 easily, so let me do them too (for other archs the Arch repo doesn't seem to have up-to-date cross compilers)

edit: no problems for aarch64 and riscv64

@folkertdev folkertdev added this pull request to the merge queue Mar 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2026
@folkertdev
Copy link
Contributor

@folkertdev folkertdev added this pull request to the merge queue Mar 4, 2026
@sayantn
Copy link
Contributor Author

sayantn commented Mar 4, 2026

probably, looks like the disassembly failed for lzcnt

Merged via the queue into rust-lang:main with commit ab59edf Mar 4, 2026
77 checks passed
@sayantn sayantn deleted the fix-signatures branch March 8, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants