Closed
Conversation
…cote Replace `visit_waiters` with `abstracted_waiters_of` This replaces `visit_waiters` which uses closures to visit waiters with `abstracted_waiters_of` which returns a list of waiters. This makes the control flow of their users a bit clearer. Additionally `abstracted_waiters_of` includes non-query waiters unlike `visit_waiters`. This means that `connected_to_root` now considers resumable waiters from the compiler root as being connected to root, while previously only non-resumable waiters counted. This can result in some additional entry points being found. Similarly in the loop detecting entry points we now consider queries in the cycle with direct resumable waiters from the compiler root as being entry points. When looking for entry points we now look at waiters until we found a query to populate the `EntryPoint.waiter` field instead of stopping when we determined it to be an entry point. cc @petrochenkov @nnethercote
Reimplement const closures Tracking issue: rust-lang#106003 Best reviewed commit-by-commit The old solver can't handle `for<'a> |x: &'a()| ()` closures in const contexts, but that feature is unstable itself, so we can just leave it to the next solver to handle. We need a lot more tests, we're testing the bare minimum of success and failure paths right now. r? @fee1-dead
…r=WaffleLapkin Fix std doctest build for SGX target. This PR fixes standard library doctest build for `x86_64-fortanix-unknown-sgx` target.
…nnethercote Remove `value_from_cycle_error` specializations This removes `value_from_cycle_error` specializations which are not involved in custom cycle error handling. This is a step towards removing query cycle recovery.
Member
Author
|
@bors r+ rollup=never p=5 |
rustbot
added
A-query-system
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Rollup of 4 pull requests
Contributor
Contributor
|
⌛ Testing commit 5bdbc6b with merge 3384f19... Workflow: https://github.com/rust-lang/rust/actions/runs/23078354550 |
This was referenced Mar 14, 2026
Member
|
@bors r- |
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. Auto build was cancelled due to unapproval. Cancelled workflows: |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
visit_waiterswithabstracted_waiters_of#153376 (Replacevisit_waiterswithabstracted_waiters_of)value_from_cycle_errorspecializations #153786 (Removevalue_from_cycle_errorspecializations)r? @ghost
Create a similar rollup