Skip to content

redox: fix signal action constant types#5009

Merged
JohnTitor merged 1 commit intorust-lang:mainfrom
xtqqczze:saflags
Mar 10, 2026
Merged

redox: fix signal action constant types#5009
JohnTitor merged 1 commit intorust-lang:mainfrom
xtqqczze:saflags

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Mar 9, 2026

Change SA_ constant types to c_int to fix a redox build error.

Follow-up to #4986

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 10, 2026
@xtqqczze
Copy link
Contributor Author

@jackpot51, @JohnTitor PTAL

Copy link
Contributor

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtqqczze
Copy link
Contributor Author

Hopefully this can be released soon and v0.2.183 yanked.

@jackpot51
Copy link
Contributor

I don't think a yank is appropriate. Redox OS is still pre-alpha, and our libc API will change as we discover portability issues.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnTitor JohnTitor added this pull request to the merge queue Mar 10, 2026
Merged via the queue into rust-lang:main with commit 4283feb Mar 10, 2026
51 checks passed
@xtqqczze
Copy link
Contributor Author

This should be backported to fix the type mismatch introduced in #4986.

@xtqqczze xtqqczze deleted the saflags branch March 11, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants