Merged
Conversation
Muscraft
force-pushed
the
fix-some-escape-codes
branch
from
e424aee to
e2d2fb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using a tool locally that depends on
anstyle-svg, I encountered some I encountered some oddities with how it handled underlines. After some investigation I found that the main cause was thatanstyle-svgdidn't support SGR 22-29, but the lack of support for591 and bug with4:0's1 implementation also caused issues.To address this I implemented
SGR 22-292 as well as59, and made4:0remove all types of underlines, not just the "base" one.Footnotes
https://sw.kovidgoyal.net/kitty/underlines/ ↩ ↩2
I did not add support for
25(Not blinking) sinceanstyle-svgdoesn't currently have support for bliking ↩