[client] Fix: require arguments for v30 getdescriptoractivity RPC
#479
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration_test/tests/blockchain.rs
Outdated
| #[cfg(not(feature = "v29_and_below"))] | ||
| { | ||
| node.client | ||
| .get_descriptor_activity(&[] as &[bitcoin::BlockHash], &[] as &[&str]) |
Collaborator
There was a problem hiding this comment.
It would be nice to pass in non-empty data so that the change in the required args is actually tested.
Contributor
Author
There was a problem hiding this comment.
Included some argument data. Btw, tysm for all the reviews!
Collaborator
There was a problem hiding this comment.
No worries, I don't mind spending time reviewing good PRs where suggestions are quickly fixed 😊.
natobritto
force-pushed
the
update-getdescriptoractivity-args
branch
from
54391fd to
9d03144
Compare
Bitcoin Core v30 marks the blockhashes and scanobjects arguments of getdescriptoractivity as required, instead of failing with a JSON parsing error when omitted.
natobritto
force-pushed
the
update-getdescriptoractivity-args
branch
from
9d03144 to
85747f8
Compare
tcharding
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitcoin Core v30 marks the
blockhashesandscanobjectsarguments ofgetdescriptoractivityRPC as required, instead of failing with a JSON parsing error when omitted.This change is listed here in Bitcoin Core's v30 release notes.
Partially fixes issue #474.