Conversation
shayonj
force-pushed
the
s/term-sginal
branch
8 times, most recently
from
581e40e to
4bdd3ae
Compare
Author
|
👋🏾 @hsbt thanks for taking a look, just updated the branch. Let me know if you have any feedback 🙏🏾 |
mblumtritt
reviewed
Jun 1, 2025
| end | ||
|
|
||
| def setup_signal_handling | ||
| Signal.trap("TERM") do |
There was a problem hiding this comment.
You should only trap signals which are supported on the platform.
Suggested change
| Signal.trap("TERM") do | |
| return unless Signal.list.include?('TERM') | |
| Signal.trap("TERM") do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In containerized workloads, it's common to receive a
SIGTERMsignal when a pod or task is shutting down. Currently, when this occurs, theraketask throws aSignalExceptionand returns a status code of1. This behavior can be misinterpreted by container orchestration systems (like Fargate, Kubernetes, etc.) as an error, rather than a graceful exit.This PR proposes that, when a
SIGTERMsignal is received by araketask, it should return an exit code of143. This exit code is the standard response for aSIGTERM, indicating a proper shutdown was acknowledged and handled gracefully.I only added this for SIGTERM, but should be extensive for other handlers too if needed in future.
Related: #272