ensures connection is closed on keepalive timeout#1118
Merged
OlegDokuka merged 6 commits into1.1.xfrom Jan 31, 2025
Merged
Conversation
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
rstoyanchev
requested changes
Jan 31, 2025
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
A couple of improvements suggested below for the test class, but otherwise looks good.
rsocket-transport-netty/src/test/java/io/rsocket/integration/KeepaliveTest.java
Show resolved
Hide resolved
| // .subscribe(); | ||
|
|
||
| // return client; | ||
| } |
Contributor
There was a problem hiding this comment.
The createClient methods maybe can also be combined into one with a lazy input argument.
rstoyanchev
changed the title
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
OlegDokuka
added a commit
that referenced
this pull request
Jan 31, 2025
* ensures connection is close on keepalive timeout Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> * fix format Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> * improve KeepaliveTest Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> * fix format and failing test Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> * adds reference to the original GH issue Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> * fixes google format Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> --------- Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1099