Add 'executor_type' parameter to ComponentManager and deprecate redundant component containers #3055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is related to issue #2930. The proposed design consists of two parts:
component_container_eventsandcomponent_container_mtand instead configuring the type ofComponentManagerwith a parameter (executor_type).ComponentManagerIsolatedandcomponent_container_isolatedand moving the functionality (with the requested feature) toComponentManageritself.Since these are two separate tasks, I think it's appropriate to open a pull request for each one. This pull request implements the first part. Let me know if I should implement both of them in a single pull request.
Is this user-facing behavior change?
Users can keep using
component_containerlike before, but instead of usingcomponent_container_mtandcomponent_container_eventsthey should usecomponent_containersupplied with the appropriate value forexecutor_typeparameter.Did you use Generative AI?
No.
Additional Information
Nothing.