perf(ProjectManager): cache PathCollection per project in flushDocumentChanges#1628
Open
bartvandenende-wm wants to merge 1 commit intorokucommunity:masterfrom
Open
Conversation
…ntChanges Previously, every document flush created a new PathCollection for each project to filter which files belong to that project. In workspaces with many projects and frequent file changes, this caused unnecessary allocations and glob compilation overhead. Cache the PathCollection per project using a WeakMap. The cache is automatically invalidated when a project is removed (and garbage collected). File patterns only change when a project is reloaded, so the cached filterer remains valid for the lifetime of the project. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In large multi-project workspaces, every document flush recompiles glob matchers for every project, even though file patterns rarely change. This is part 3 of 3 targeted improvements to language server performance at scale (Part of #1625).
Summary
Caches
PathCollectioninstances per project to avoid redundantmicromatch.matcher()compilation on every document flush.WeakMapto lazily create and cachePathCollectionper projectTest plan
PathCollectioninstances are reused across flushesflushDocumentChangestests pass unchanged