[MAIN-2678] Fixing missing slack sink workload#1705
[MAIN-2678] Fixing missing slack sink workload#1705Avi-Robusta wants to merge 5 commits intomasterfrom
Conversation
arikalon1
left a comment
There was a problem hiding this comment.
nice work
left a small comment
| finding_data = finding.attribute_map | ||
| # The top level entity name (the owner of the pod etc) | ||
| finding_data["workload"] = finding.service.name if finding.service else None | ||
| finding_data["workload"] = finding.service.name if finding.service else finding.backup_workload_name |
There was a problem hiding this comment.
why are we doing it only for Slack?
it's probably useful on other places as well
There was a problem hiding this comment.
i saw that workload only exists for slack, we can do this for the robusta sink if you think too
|
Warning Rate limit exceeded@moshemorad has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
if the workload does not exist, like the pod or deployment is deleted it falls back to using the prometheus labels for sinc matching