Merged
Conversation
bgentry
force-pushed
the
bg/fix-jobs-route-redirect-loop
branch
from
9400251 to
2e9e996
Compare
Contributor
Author
|
wooo, a user confirmed this fixes it: #495 (comment) |
brandur
approved these changes
Feb 6, 2026
Collaborator
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Cool. Really nice to get this fixed up!
On slower connections, opening a job from a filtered jobs list could bounce back to /jobs/. JobSearch was re-emitting debounced filter updates on unrelated rerenders, and the jobs route treated those callbacks as replace navigations even when search params were unchanged. That could override an in-flight transition to /jobs/$jobId. The filter parser result is now memoized in useFilterInput so onFiltersChange is not retriggered when input text has not changed. The jobs route now compares derived filter search params against current params and skips navigation when the update is a no-op. A regression test was added to JobSearch to ensure an unrelated rerender does not notify the parent of filter changes. Closes #495.
bgentry
force-pushed
the
bg/fix-jobs-route-redirect-loop
branch
from
2e9e996 to
9fc0177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On slower connections, opening a job from a filtered jobs list could bounce back to /jobs/. JobSearch was re-emitting debounced filter updates on unrelated rerenders, and the jobs route treated those callbacks as replace navigations even when search params were unchanged. That could override an in-flight transition to /jobs/$jobId.
The filter parser result is now memoized in useFilterInput so onFiltersChange is not retriggered when input text has not changed. The jobs route now compares derived filter search params against current params and skips navigation when the update is a no-op.
A regression test was added to JobSearch to ensure an unrelated rerender does not notify the parent of filter changes.
Closes #495.