Stringify response body in case it is an object#7
Open
forestjohnsonilm wants to merge 1 commit intorequest:masterfrom
Open
Stringify response body in case it is an object#7forestjohnsonilm wants to merge 1 commit intorequest:masterfrom
forestjohnsonilm wants to merge 1 commit intorequest:masterfrom
Conversation
Author
|
I used I realize that the user can just read the docs and implement their own logging handler, but I think that the default behavior should work instead of not work. My colleague was convinced that this poor logging was the result of the HTTP server returning simplified responses for security reasons. |
|
Stringify always might be too bold and risky. Thoughts on this instead which checks for a JSON content-type in the return? Alternatively, can check if the body is valid JSON regardless of headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
console.log({ errors: [{ exception: "GreedyLittleHandsException", message: "No pie for you!!" }] })Will output:
{ errors: [Object] }Which is not what I want.