Improve transformation of inputs passed to Function.create()#95
Open
Improve transformation of inputs passed to Function.create()#95
Conversation
This fixes an issue where the instance rather than the class was passed into use resulting in an exception when performing the `isinstance` check in `use()`.
Currently we only convert `URLPath` instances into URL strings if passed directly as an input parameter. We want to ensure that we convert all instances of `URLPath`s provided otherwise we get JSON encoding errors. The most common use of this is passing a list of files that were output from another model. This PR attempts to transform the most common Python data structures into either lists or dicts and in doing so extracts the underlying URL value from any `URL` path instances. This might be better implemented as a custom JSON encoder.
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only convert
URLPathinstances into URL strings if passed directly as an input parameter. We want to ensure that we convert all instances ofURLPaths provided otherwise we get JSON encoding errors.The most common use of this is passing a list of files that were output from another model. Here is a minimal reproduction:
This can be run with:
This PR attempts to transform the most common Python data structures into either lists or dicts and in doing so extracts the underlying URL value from any
URLpath instances.Note
This might be better implemented as a custom JSON encoder.