chore: add #[must_use] to error type constructors#22
Merged
Conversation
Add #[must_use] attribute to CodecError::new() and ValidationError::new() to ensure callers use the returned error value, consistent with other constructor methods in the codebase.
refcell
commented
Feb 2, 2026
Owner
Author
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
LGTM! The #[must_use] annotations on error constructors ensure callers handle the returned values properly. This follows the established pattern in the codebase.
Note: ValidationError::invalid_params() is also missing #[must_use] (similar constructor), but that's minor and can be addressed separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[must_use]attribute toCodecError::new()incrates/traits/src/codec.rs#[must_use]attribute toValidationError::new()incrates/rpc/src/validator.rsThis ensures callers handle the returned error values rather than accidentally discarding them, consistent with other constructor methods in the codebase.
Changes
Adds the
#[must_use]attribute to two error type constructors that were missing it.