Skip to content

Comments

feat(repo-server): Build system CA trust from user configured sources#987

Merged
jgwest merged 7 commits intoredhat-developer:masterfrom
olivergondza:system-ca-trust
Feb 25, 2026
Merged

feat(repo-server): Build system CA trust from user configured sources#987
jgwest merged 7 commits intoredhat-developer:masterfrom
olivergondza:system-ca-trust

Conversation

@olivergondza
Copy link
Collaborator

@olivergondza olivergondza commented Oct 10, 2025

Note this PR updated dependencies of GO(1.25.5), argocd-operator and argo-cd(3.3.0)!

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Downstream version of argoproj-labs/argocd-operator#1876.

Have you updated the necessary documentation?

  • [no] Documentation update is required by this PR.
  • [no] Documentation has been updated.

Which issue(s) this PR fixes:

Implements argoproj-labs/argocd-operator#1830

Test acceptance criteria:

  • [no] Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Oct 10, 2025
@openshift-ci openshift-ci bot requested review from anandrkskd and wtam2018 October 10, 2025 12:51
@olivergondza olivergondza changed the title feat(repo-server): Build system CA trust from use configured sources feat(repo-server): Build system CA trust from user configured sources Oct 10, 2025
@olivergondza
Copy link
Collaborator Author

/retest

@olivergondza olivergondza force-pushed the system-ca-trust branch 2 times, most recently from a2fbb78 to db843d4 Compare October 27, 2025 12:09
@olivergondza
Copy link
Collaborator Author

/retest

@olivergondza
Copy link
Collaborator Author

/retest

@olivergondza olivergondza force-pushed the system-ca-trust branch 2 times, most recently from a48645f to 2bb059d Compare February 12, 2026 19:38
@svghadi
Copy link
Member

svghadi commented Feb 16, 2026

/lgtm

@olivergondza
Copy link
Collaborator Author

/retest-required

@openshift-ci openshift-ci bot removed the lgtm label Feb 16, 2026
@olivergondza olivergondza force-pushed the system-ca-trust branch 3 times, most recently from 1d6fbd2 to 8717a85 Compare February 17, 2026 13:58
@olivergondza
Copy link
Collaborator Author

/retest

@olivergondza
Copy link
Collaborator Author

/retest

2 similar comments
@olivergondza
Copy link
Collaborator Author

/retest

@olivergondza
Copy link
Collaborator Author

/retest

@keithchong
Copy link
Contributor

Hi @anandf , @svghadi can we please merge this?

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…implementation

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@svghadi
Copy link
Member

svghadi commented Feb 25, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 25, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svghadi
Copy link
Member

svghadi commented Feb 25, 2026

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

@olivergondza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-e2e 81e4ede link true /test v4.14-e2e
ci/prow/v4.14-kuttl-parallel 81e4ede link false /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential 81e4ede link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgwest
Copy link
Member

jgwest commented Feb 25, 2026

Merging as this was previously approved, and the only E2E tests that are failing are a known infrastructure issue that is also failing other PRs at the moment.

@jgwest jgwest merged commit 60437bc into redhat-developer:master Feb 25, 2026
12 of 16 checks passed
@olivergondza olivergondza deleted the system-ca-trust branch February 25, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants