Add Dynamic HTTP Status Code for JSON Responses in React\Http\Message\Response#507
Open
emrancu wants to merge 3 commits intoreactphp:1.xfrom
Open
Add Dynamic HTTP Status Code for JSON Responses in React\Http\Message\Response#507emrancu wants to merge 3 commits intoreactphp:1.xfrom
emrancu wants to merge 3 commits intoreactphp:1.xfrom
Conversation
WyriHaximus
reviewed
Nov 15, 2023
src/Message/Response.php
Outdated
| * @throws \InvalidArgumentException when encoding fails | ||
| */ | ||
| public static function json($data) | ||
| public static function json($data, $status = null) |
Member
There was a problem hiding this comment.
This should also work:
Suggested change
| public static function json($data, $status = null) | |
| public static function json($data, $status = self::STATUS_OK) |
Member
|
Hey @emrancu, thank you for contributing to ReactPHP! ❤️ The $response = new React\Http\Message\Response(
React\Http\Message\Response::STATUS_OK,
[
'Content-Type' => 'application/json'
],
json_encode(
['name' => 'Alice'],
JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | JSON_PRESERVE_ZERO_FRACTION
) . "\n"
);This way you can directly use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the React\Http\Message\Response class by introducing the ability to set dynamic HTTP status codes for JSON responses.
This feature provides developers with the flexibility to adapt status codes based on contextual requirements.