Adds TypeScript types to **all** logger examples in the React Compiler logger documentation to provide better IntelliSense and type safety throughout.#8246
Open
kanikaa88 wants to merge 5 commits intoreactjs:mainfrom
Conversation
Improve the explanation in the 'Fetching data' section to clearly distinguish when an Effect is needed (synchronization with external system) versus when it's not needed (user events, data transformation). Closes reactjs#8226
Add import type and satisfies Logger to the basic logging example to provide better IntelliSense and type safety for users. Fixes reactjs#8245
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Explain that JSX braces expect expressions, not statements, and show how to use if before return vs expression forms inline. Fixes reactjs#8247
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds TypeScript types to all logger examples in the React Compiler logger documentation to provide better IntelliSense and type safety throughout.
Problem
The current examples don't include TypeScript types, which means:
Solution
Added TypeScript types to all three examples:
Each example now includes:
import type { Logger } from 'babel-plugin-react-compiler'satisfies Loggerfor type safetyChanges
satisfies Loggerto all logger objectsjstotsWhy
satisfies?The
satisfieskeyword ensures type safety without losing the inferred types offilenameandeventparameters. This gives developers the best of both worlds - type checking and helpful autocomplete.Testing
✅ Verified all code syntax is correct
✅ All examples follow consistent pattern
✅ Follows the pattern suggested in the issue
Fixes #8245