fix: preserve default className when className is null or undefined#599
Open
Shiva903-hue wants to merge 1 commit intoreactjs:mainfrom
Open
fix: preserve default className when className is null or undefined#599Shiva903-hue wants to merge 1 commit intoreactjs:mainfrom
Shiva903-hue wants to merge 1 commit intoreactjs:mainfrom
Conversation
danez
requested changes
Jan 29, 2026
Collaborator
danez
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I left some comments.
Comment on lines
+392
to
+411
| // Only pass valid DOM attributes and data- attributes | ||
| const domAttributes = {}; | ||
| Object.keys(restProps).forEach((key) => { | ||
| if ( | ||
| key.startsWith('data-') || | ||
| key === 'id' || | ||
| key === 'style' || | ||
| key === 'title' || | ||
| key === 'role' || | ||
| key === 'tabIndex' || | ||
| key === 'aria-label' || | ||
| key === 'aria-labelledby' || | ||
| key === 'aria-describedby' || | ||
| key === 'aria-controls' || | ||
| key === 'aria-selected' || | ||
| key === 'aria-disabled' | ||
| ) { | ||
| domAttributes[key] = restProps[key]; | ||
| } | ||
| }); |
Collaborator
There was a problem hiding this comment.
This domAttributes is not needed. We remove all custom props above and pass on everything else.
Suggested change
| // Only pass valid DOM attributes and data- attributes | |
| const domAttributes = {}; | |
| Object.keys(restProps).forEach((key) => { | |
| if ( | |
| key.startsWith('data-') || | |
| key === 'id' || | |
| key === 'style' || | |
| key === 'title' || | |
| key === 'role' || | |
| key === 'tabIndex' || | |
| key === 'aria-label' || | |
| key === 'aria-labelledby' || | |
| key === 'aria-describedby' || | |
| key === 'aria-controls' || | |
| key === 'aria-selected' || | |
| key === 'aria-disabled' | |
| ) { | |
| domAttributes[key] = restProps[key]; | |
| } | |
| }); |
| return ( | ||
| <div | ||
| {...attributes} | ||
| {...domAttributes} |
Collaborator
There was a problem hiding this comment.
Suggested change
| {...domAttributes} | |
| {...attributes} |
| environment, // unused here | ||
| disableUpDownKeys, // unused here | ||
| disableLeftRightKeys, // unused here | ||
| ...restProps |
Collaborator
There was a problem hiding this comment.
Suggested change
| ...restProps | |
| ...attributes |
Comment on lines
+413
to
+414
| const className = | ||
| propClassName == null ? defaultProps.className : propClassName; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const className = | |
| propClassName == null ? defaultProps.className : propClassName; | |
| const className = propClassName ?? defaultProps.className; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves the default
react-tabsclassName inUncontrolledTabswhenprops.classNameisundefinedornull.Why?
Currently, spreading
{ ...defaultProps, ...props }causes an explicitundefinedornullclassName to override the default, which breaksbackward compatibility and styling.
Maintainers confirmed this behavior in #581.
What’s included
undefined/nulloverridesRelated issue
Fixes #581