add Radius testnet / mainnet#3
Conversation
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
| "name": "Radius Network Testnet", | ||
| "chain": "RAD", | ||
| "name": "Radius Testnet", | ||
| "chain": "RADIUS", |
There was a problem hiding this comment.
I think "Network" is intentional here (cc: @AlBorison @kevinkarwaski )
There was a problem hiding this comment.
I hope we don't do this... Radius Network Testnet sounds clunky.
There was a problem hiding this comment.
I think this is to deduplicate from https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-863.json
There was a problem hiding this comment.
Aah, I see. Do we have to be unique though?
| }, | ||
| "infoURL": "https://radiustech.xyz", | ||
| "shortName": "rad", | ||
| "shortName": "radius-testnet", |
There was a problem hiding this comment.
How long should a shortName be?
There was a problem hiding this comment.
I did a quick look through the others and we're not the outlier. There's tons - like superposition-testnet that are very significantly longer. Here's more:
_data/chains/eip155-920637907288165.json: "shortName": "kkrt-starknet-sepolia",
_data/chains/eip155-1722641160.json: "shortName": "silicon-sepolia-testnet",
| "chainId": 72344, | ||
| "networkId": 72344, | ||
| "icon": "rad", | ||
| "slip44": 1, |
There was a problem hiding this comment.
its a hint for the path of HD wallets - like 1/0/0/0 or whatever. its one of those fields. testnets are always 1 whereas mainnets are like 44 or something - i forget
_data/chains/eip155-723.json
Outdated
| "name": "Radius", | ||
| "chain": "RADIUS", |
There was a problem hiding this comment.
This probably also wants to be Radius Network
|
@maurermi is on this; let's close this out and let him finish. We've debated / discussed the labeling at length with @TJ-Frederick and @AlBorison and landed on these words intentionally for various reasons. If there is any question or concern, let's take it to slack or in-person convo. |
|
Reached a détente with @AlBorison / @TJ-Frederick on this - "Radius Network" and "Radius Test Network" - removes the redundancy in the test network name. Will update the PR. |
maurermi
left a comment
maurermi
left a comment
There was a problem hiding this comment.
Not sure why the CI is failing, but if we can fix that and merge then we can PR upstream
|
I'm just going to merge this and resolve the CI in a new PR |
|
PR merged - please consider contributing some funds to lists.eth |
3 participants
this builds on what @maurermi / @kevinkarwaski did but also adds mainnet. only potentially controversial thing here is not calling it "Radius Network", but rather just "Radius". To me, "Radius Network Testnet" sounds overly wordy.