Skip to content

Document search result highlighting for websites#1927

Merged
cderv merged 5 commits intoprereleasefrom
new-search
Mar 4, 2026
Merged

Document search result highlighting for websites#1927
cderv merged 5 commits intoprereleasefrom
new-search

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Mar 2, 2026

Summary

  • Add new "Search Result Highlighting" section to website-search.qmd documenting highlight persistence, automatic tab activation for tabsets, cross-element highlighting, and section anchor support
  • Add light/dark screenshots showing tab activation and code block highlighting
  • Add entry to 1.9 prerelease highlights

Documents features from quarto-cli PRs:

@cderv cderv requested a review from cwickham March 2, 2026 17:39
@cderv
Copy link
Collaborator Author

cderv commented Mar 2, 2026

@cwickham maybe the screenshot should be more zoomed ? What do you think ?

edit: seeing the preview, I think we should definitely zoom on body page or somehow zoom viewport.
It would be good to have some common settings to be used throughout the website

@github-actions github-actions bot temporarily deployed to pull request March 2, 2026 17:49 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1927.quarto.org

🔄 Modified Documents

Copy link
Collaborator

@cwickham cwickham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I agree about the screenshot. The whole-page context is useful, but the highlighted text ends up too small. I'd zoom in (where zoom is browser zoom) to increase text size, but keep context (e.g. TOC on right).

@cderv
Copy link
Collaborator Author

cderv commented Mar 2, 2026

Thanks for the review, I'll handle tomorrow

Add new section to website-search.qmd covering highlight persistence, automatic tab activation, cross-element highlighting, and section anchor  support. Add light/dark screenshots and prerelease highlights entry.
@github-actions github-actions bot temporarily deployed to pull request March 3, 2026 15:29 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1927.quarto.org

🔄 Modified Documents

@github-actions github-actions bot temporarily deployed to pull request March 3, 2026 15:49 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1927.quarto.org

🔄 Modified Documents

cderv and others added 2 commits March 3, 2026 16:50
Co-authored-by: Charlotte Wickham <charlotte.wickham@posit.co>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1927.quarto.org

🔄 Modified Documents

@github-actions github-actions bot temporarily deployed to pull request March 3, 2026 16:41 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1927.quarto.org

🔄 Modified Documents

@cderv cderv merged commit 8f14451 into prerelease Mar 4, 2026
4 checks passed
@cderv cderv deleted the new-search branch March 4, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants