Fix CI: install rsvg-convert and verapdf when running all tests#14143
Merged
Fix CI: install rsvg-convert and verapdf when running all tests#14143
Conversation
The update-test-timing.yml and daily test-smokes.yml schedule runs
pass `buckets: ""` (all tests), but rsvg-convert and verapdf were
only installed when `buckets` contained specific bucket names. This
caused 4 pdf-standard/ua-* tests to fail every run since Jan 26.
Use the same `format('{0}', inputs.buckets) == ''` pattern already
used elsewhere in this workflow to detect all-tests mode.
Fixes weekly timing update failures and daily schedule failures.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update-test-timing.ymland dailytest-smokes.ymlschedule runs passbuckets: ""(run all tests), butrsvg-convertandverapdfwere only installed wheninputs.bucketscontained specific bucket name strings likerender-pdf-svg-conversionorpdf-standard. This caused 4pdf-standard/ua-*tests to fail on every scheduled run since Jan 26, 2026.Root Cause
The conditional install steps used
contains(inputs.buckets, '...')which is false whenbucketsis empty. Parallel smoke test runs pass because each bucket string contains the test file paths which match the condition.Failing tests:
ua-missing-alt.qmd,ua-image-alt-text.qmd,ua-figure-missing-alt.qmd— missingrsvg-convertfor SVG-to-PDF conversionua-missing-title.qmd— missingverapdffor PDF/UA validation warningsFix
Add
format('{0}', inputs.buckets) == ''to both install conditions, using the same pattern already used elsewhere in this workflow (lines 253, 262) to detect all-tests mode.Fixes weekly
update-test-timing.ymlfailures and daily schedule failures.