-
Notifications
You must be signed in to change notification settings - Fork 414
Fix: Vertical alignment div has no effect for pdf output #13658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+99
−288
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
72b182a
Fix: Vertical alignment div has no effect for pdf output
MBe-iUS 2d44070
Inform changelog
MBe-iUS 4e884cc
Handle valign_class is nil
MBe-iUS dba95cb
Escape lua pattern hyphen
MBe-iUS 95b81c6
Adapt test file snapshot
MBe-iUS 2cb5f09
New test for valign=bottom
kernie aa7c2d3
Merge branch 'quarto-dev:main' into main
MBe-iUS f6d07dd
Merge branch 'main' into main
MBe-iUS a00933a
Merge branch 'main' into main
MBe-iUS b17f42a
Merge branch 'main' into main
MBe-iUS 5cd44ae
Merge branch 'main' into main
MBe-iUS 467bf6b
Merge branch 'main' into pr-13658
cderv 9008420
Move changelog in correct place
cderv da91d55
Typo in comment
cderv b942a52
kLayoutVAlign already removed
cderv 2b3d6fc
Fix layout-valign tests to match positional argument in minipage
cderv d84d5ce
Add test for layout-valign with plain markdown content
cderv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| title: "Untitled" | ||
| format: | ||
| pdf: | ||
| keep-tex: true | ||
| execute: | ||
| warning: false | ||
| _quarto: | ||
| tests: | ||
| pdf: | ||
| ensureLatexFileRegexMatches: | ||
| - ['\\begin\{minipage\}\[c\]\{0\.50\\linewidth\}'] | ||
| - [] | ||
| --- | ||
|
|
||
| ```{r} | ||
| #| label: tbl-tables | ||
| #| tbl-cap: "Tables" | ||
| #| tbl-subcap: | ||
| #| - cars | ||
| #| - pressure | ||
| #| layout-ncol: 2 | ||
| #| layout-valign: center | ||
|
|
||
| library(knitr) | ||
| kable(head(cars)) | ||
| kable(head(pressure)) | ||
| ``` | ||
|
|
||
| See @tbl-tables for examples. In particular, @tbl-tables-2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| format: | ||
| pdf: | ||
| keep-tex: true | ||
| _quarto: | ||
| tests: | ||
| pdf: | ||
| ensureLatexFileRegexMatches: | ||
| - ['\\begin\{minipage\}\[t\]'] | ||
| - [] | ||
| --- | ||
|
|
||
| ::: {layout="[40, -2, 40]" layout-valign="top"} | ||
|
|
||
| Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. | ||
|
|
||
| Lorem ipsum dolor sit amet, consectetur adipiscing elit | ||
|
|
||
| ::: |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.