Open
Conversation
It is now on par with tutorial http://pytorch.org/tutorials/advanced/cpp_extension.html change AT_ASSERTM by TORCH_CHECK change .type() by .scalar_type() change PackedAcessor to PackedAccessor32 change fminf and fmaxf to their fmin and fmax counterparts, make sur that the right template is used by casting the 0.0 to scalar_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the tutorial was updated but not the codebase, so here it goes.
It is now on par with tutorial http://pytorch.org/tutorials/advanced/cpp_extension.html
change AT_ASSERTM by TORCH_CHECK
change .type() by .scalar_type()
change PackedAcessor to PackedAccessor32
This hopefully fixes #65 , #66 (although 1.6 norally only return deprecation warning)
Second significant change :
change fminf and fmaxf to their fmin and fmax counterparts, make sur that the right template is used by casting the 0.0 to scalar_t . This is probably not needed anymore as it was probably a bug with nvcc and gcc7 but it might help people with old configs get the grad_check working.
This fixes #27 and #42