Draft: Integration of `QuantizeFusedConvBnBiasPass` to NXP conversion pipeline by StrycekSimon · Pull Request #17523 · pytorch/executorch

StrycekSimon · 2026-02-18T13:09:01Z

This is a placeholder PR used as demonstration of integration of changes applied in this pull request.

Includes testing function for reference.

Summary: When performing QAT with a model that has a conv layer with no bias followed by batch norm, the fusion process creates a bias. This is done *after* observers are attached so the resulting bias is kept as float. This diff adds a pass which grabs the proper qparams and applies them to the non-quantized bias. Differential Revision: D92733079

pytorch-bot · 2026-02-18T13:09:05Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17523

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 38 New Failures

As of commit 1875eec with merge base 6c1dc31 ():

NEW FAILURES - The following jobs have failed:

pull / test-binary-size-linux-gcc / linux-job (gh)
RuntimeError: Command docker exec -t b6518057d64286f1d4a0e26dac7906f0ed351c3cd9e98aa530e90ab39056d886 /exec failed with exit code 1
pull / test-coreml-bc-macos (macos-m1-stable) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / test-coreml-bc-macos (macos-m2-stable) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / test-lora-multimethod-linux / linux-job (gh)
RuntimeError: Command docker exec -t 2cf17793ed9bad612fe331f280db1fc6026e5b1569f4f4b5452f0286753c6d4a /exec failed with exit code 127
pull / test-parakeet-xnnpack-linux / linux-job (gh)
RuntimeError: Command docker exec -t 13c80b9330ad6b800c74d3850a861a69fd536fe828f59e824442e92369b1161c /exec failed with exit code 1
pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 281ae9c9a994d34d6a86f1adb92b262f2c76533f8e5ac9dfdf85bc236a9e30e3 /exec failed with exit code 1
pull / test-samsung-quantmodels-linux / linux-job (gh)
RuntimeError: Command docker exec -t 995cf36f31043bf4b16d8956f43cd80b6b02fb969afc825e0859d20d6ae7799d /exec failed with exit code 1
pull / test-voxtral-realtime-xnnpack-linux / linux-job (gh)
RuntimeError: Command docker exec -t 0874da2fe6346421ccea590f79f1ca1b657a2401b677546a2cb79c1df029ac96 /exec failed with exit code 1
pull / test-vulkan-operators-linux / linux-job (gh)
RuntimeError: Command docker exec -t 059c169ab123226c5a08b88755d9e03a62a8f5993b781fd8701284d2402efd25 /exec failed with exit code 127
pull / unittest / linux / linux-job (gh)
/tmp/pip-build-env-r1ql8f70/overlay/lib/python3.10/site-packages/pybind11/include/pybind11/pybind11.h:2462:25: error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / unittest / windows / windows-job (gh)
Process completed with exit code 1.
pull / unittest-arm-backend-with-no-deps (test_pytest_models_tosa) / linux-job (gh)
/tmp/pip-build-env-5zy43p60/overlay/lib/python3.10/site-packages/pybind11/include/pybind11/pybind11.h:2462:25: error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.
pull / unittest-arm-backend-with-no-deps (test_pytest_ops_no_target) / linux-job (gh)
/tmp/pip-build-env-oi8xk8w5/overlay/lib/python3.10/site-packages/pybind11/include/pybind11/pybind11.h:2462:25: error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.
pull / unittest-arm-backend-with-no-deps (test_pytest_ops_tosa) / linux-job (gh)
/tmp/pip-build-env-rryzkh7n/overlay/lib/python3.10/site-packages/pybind11/include/pybind11/pybind11.h:2462:25: error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.
pull / unittest-arm-backend-with-no-deps (test_run_tosa) / linux-job (gh)
/tmp/pip-build-env-g9kjk_9p/overlay/lib/python3.10/site-packages/pybind11/include/pybind11/pybind11.h:2462:25: error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.
pull / unittest-buck / linux / linux-job (gh)
RuntimeError: Command docker exec -t 4d028a6fcdfeda2a7a2dc3cfba15c4561ab699bab066e4896f47325072d91f9e /exec failed with exit code 3
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 3
pull / unittest-editable / linux / linux-job (gh)
/tmp/pip-build-env-4epmdgf1/overlay/lib/python3.10/site-packages/pybind11/include/pybind11/pybind11.h:2462:25: error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / unittest-editable / windows / windows-job (gh)
Process completed with exit code 1.
pull / unittest-nxp-neutron / linux-job (gh)
RuntimeError: Command docker exec -t 86f4baa7e767644a1e8414e2612b5c9180aa0689d8b3db8563fd7c825e615926 /exec failed with exit code 1
Test CUDA Builds / check-all-cuda-builds (gh)
Process completed with exit code 1.
Test CUDA Builds / test-executorch-cuda-build-12.6 / linux-job (gh)
RuntimeError: Command docker exec -t 5280f6474dcd4918b13adc4742665f3db757546ef72c6b8a4d77a716c4578f03 /exec failed with exit code 1
Test CUDA Builds / test-executorch-cuda-build-12.8 / linux-job (gh)
RuntimeError: Command docker exec -t b0a92b6b77d1a1238203a877e0944f62b7398565db302d4b8be2692eb6d062dd /exec failed with exit code 1
Test CUDA Builds / test-executorch-cuda-build-12.9 / linux-job (gh)
RuntimeError: Command docker exec -t 29229e7fccb41df2d12cb8122912996a5c18e9be810dd28f2ffd6361c14a56b5 /exec failed with exit code 1
Test CUDA Builds / test-executorch-cuda-build-13.0 / linux-job (gh)
RuntimeError: Command docker exec -t f4ddd147c0c59f352e95a5855824e843f5b576e328cd5d24dd830f48ca8910a2 /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (add_mul) / linux-job (gh)
RuntimeError: Command docker exec -t 21c1d8256a20e8a7a60f59be08fd778a6ed6e4433db66f7f489f27b7d73fb448 /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (add) / linux-job (gh)
RuntimeError: Command docker exec -t 4d7cf31bf7053a5969bad19a9d86ce44d2f2d7a56be02a90cca637f8d75e6f8d /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (conv1d) / linux-job (gh)
RuntimeError: Command docker exec -t 9de001467edacd54de41344fd12f25ab17123129c8620815e6d8709726da9a00 /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (linear) / linux-job (gh)
RuntimeError: Command docker exec -t 92772e186e4aaf8ae5262fd3a01517c6a79da77a58882f5d0c43def1cf3efd70 /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (mv2) / linux-job (gh)
RuntimeError: Command docker exec -t 5c77cab1347d0524f0b41052527a965c7a0966084216ea851040452359dcf6c5 /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (mv3) / linux-job (gh)
RuntimeError: Command docker exec -t 97a85cc28bb0325f14765c70ac2954fa652f8782c05ed31d9ae4ebd0f43bbbab /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh)
RuntimeError: Command docker exec -t 4269bc931ab690a08c2e22b0c1e90a5244f298e8021232358a84cd9d033ce3a7 /exec failed with exit code 1
Test CUDA Builds / test-models-cuda (sdpa) / linux-job (gh)
RuntimeError: Command docker exec -t 47f8a9f35fef6596dd05c92f6954a404fa5f9b48729bfac5a7b26db89d6b0d9e /exec failed with exit code 1
Test CUDA Builds / unittest-cuda / linux-job (gh)
RuntimeError: Command docker exec -t a522cbd703c7fbec46c418f135e4be02834a3d7f4e354300dfa877dcfd2948ba /exec failed with exit code 1
Test Metal Backend / test-executorch-metal-build / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
Test Metal Backend / test-metal-backend-modules / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2026-02-18T13:09:47Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JakeStevens · 2026-02-19T21:06:24Z

backends/nxp/quantizer/utils.py

+    module = convert_pt2e(module)
+
+    # Without this export, conv bias is not in the graph_signature.
+    model = torch.export.export(module, calibration_inputs[0], strict=True)


So you want to try to drop needing this?

JakeStevens · 2026-02-19T21:06:45Z

backends/nxp/quantizer/utils.py

+    model = bias_quant_pass(model.graph_module)

-    return m
+    return model.graph_module


is the change to use graph_module desired outcome or currently just needed for the pass as is?

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2026

StrycekSimon requested a review from JakeStevens February 18, 2026 13:10

Add QuantizeFusedConvBnBiasPass to NXP conversion pipeline

1875eec

StrycekSimon force-pushed the convbn_no_bias_pass_nxp_pipeline branch from 6c04a6e to 1875eec Compare February 18, 2026 13:14

JakeStevens reviewed Feb 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Draft: Integration of `QuantizeFusedConvBnBiasPass` to NXP conversion pipeline#17523

Draft: Integration of `QuantizeFusedConvBnBiasPass` to NXP conversion pipeline#17523
StrycekSimon wants to merge 2 commits intopytorch:mainfrom
nxp-upstream:convbn_no_bias_pass_nxp_pipeline

StrycekSimon commented Feb 18, 2026 •

edited

Loading

Uh oh!

pytorch-bot bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

JakeStevens Feb 19, 2026

Uh oh!

JakeStevens Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

StrycekSimon commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17523

❌ 38 New Failures

Uh oh!

github-actions bot commented Feb 18, 2026

This PR needs a release notes: label

Uh oh!

JakeStevens Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

JakeStevens Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

StrycekSimon commented Feb 18, 2026 •

edited

Loading

pytorch-bot bot commented Feb 18, 2026 •

edited

Loading

This PR needs a `release notes:` label