Batch of improvements (spam protection, moderation, emailing, cron, UI/UX)#345
Open
Gouterman wants to merge 1 commit intopytition:masterfrom
Open
Batch of improvements (spam protection, moderation, emailing, cron, UI/UX)#345Gouterman wants to merge 1 commit intopytition:masterfrom
Gouterman wants to merge 1 commit intopytition:masterfrom
Conversation
- Spam protection - Moderation - Emailing - Cron - UX and UI with partial theming support Signed-off-by: Luc Didry <luc@didry.org> Signed-off-by: Thomas Citharel <tcit@tcit.fr> Signed-off-by: Adrien Sch <adrien@framasoft.org>
Member
|
Hello @Gouterman and thank you for contributing back to upstream! That's a veeeeery big PR/single-commit. To facilitate the real review I propose that I do a first basic review that will propose a plan to split this in several commits (like dependency updates, re-indent, trailing spaces ...) then I'll let you do the split itself. I must warn that this won't happen very soon as I have a few months worth of other things to deal with before having free time to work on Pytition again. Sorry about that. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the long PR that mixes several improvements.
This represents several months of work (years?) initiated at Framasoft that I have grouped into a single PR. These changes had not previously been pushed upstream.
I had to go through more than a hundred commits. For the sake of simplicity, I split them into two main commits: one for internal Framasoft-specific customizations (which remain on our GitLab instance), and one containing the improvements proposed here.
The proposed improvements concern: