Reduce repeated calls to node name and type#131
Open
transoceanic2000 wants to merge 1 commit intopythonicrubyist:masterfrom
Open
Reduce repeated calls to node name and type#131transoceanic2000 wants to merge 1 commit intopythonicrubyist:masterfrom
transoceanic2000 wants to merge 1 commit intopythonicrubyist:masterfrom
Conversation
In the main loop we may call node.name and node.node_type several times. node.name in particular results in allocation of a string, boosting memory usage. Calling them once and storing them locally will reduce memory use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt to help with #122
In the main loop we may call
node.nameandnode.node_typeseveral times in differentifstatement.node.namein particular results in allocation of a string, boosting memory usage. Calling them once and storing them locally reduces memory use.In a test reading 10k (mostly empty) rows from a spreadsheet can see that the extra allocations from calling
node.namein later branches of the if disappear from the stats. Overall %age reduction in allocations is small (~2% in this case), so won't fix the memory usage but will help. %age reduction may be larger for sheets that contain more cells, as the later branches will be exercised more often.