Replace typing_extensions -> typing in examples#1987
Merged
srittau merged 5 commits intopython:mainfrom Aug 20, 2025
Merged
Conversation
|
|
||
| import enum | ||
| from typing_extensions import Never | ||
| from typing import Never |
Member
There was a problem hiding this comment.
Let's discuss on the issue for now
srittau
requested changes
Aug 20, 2025
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, and sorry for the delay. I think your hybrid approach is the best of both worlds. A few remarks below.
|
|
||
| import enum | ||
| from typing_extensions import Never | ||
| from typing import Never |
Collaborator
There was a problem hiding this comment.
Never needs an infobox as well. (Added in Python 3.11.)
Contributor
Author
There was a problem hiding this comment.
I think I didn't add it for that one because it's already explained in the prose at the start of the page; but I've added an additional infobox below the code snippet now for consistency (and perhaps easier discoverability for people who only skim the page) 👍
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1986.