Better handling for uncaught top-level exceptions#20749
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Feb 5, 2026
Merged
Better handling for uncaught top-level exceptions#20749ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
reviewed
Feb 5, 2026
| mypy.errors.report_internal_error(e, None, 0, None, options) | ||
| except Exception: | ||
| pass | ||
| sys.stdout.write(traceback.format_exc()) |
Collaborator
There was a problem hiding this comment.
should this be behind an else, i.e. don't print a traceback if report_internal_error does its thing?
Member
Author
There was a problem hiding this comment.
No, because report_internal_error() already has sys.exit(2). I tested various scenarios locally, they all look good.
hauntsaninja
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20633
This has few improvements:
--show-traceback(if possible), and write official error message.This mostly affects bug in incremental mode, where a crash occurs in top-level and/or cache loading, rather that during processing files (where we already have the error catching logic).