[mypyc] Add write_i16_le and read_i16_le to librt.strings#20745
Merged
[mypyc] Add write_i16_le and read_i16_le to librt.strings#20745
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
p-sawicki
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are experimental optimized primitives for reading/writing 16-bit binary integers. I'll later add support for other integer sizes and floats, and big endian formats.
The main optimization here is to inline the hot paths of these functions. Also the api is optimized for performance and not really ergonomics, though I don't think the ergonomics are particularly bad. When reading, the caller needs to keep track of the index to the bytes object, and negative indexes aren't supported, but the latter doesn't seem really useful for these kinds of primitives.
In a microbenchmark, these can be dozens of times faster than using stdlib
struct(when compiled).It may still be possible to further optimize performance, but these seem already pretty good.
I used coding agent assist but through small human reviewed increments.