gh-144533: Use pybuilddir.txt to find _sysconfigdata for WASI#144535
Open
therohityadav wants to merge 1 commit intopython:mainfrom
Open
gh-144533: Use pybuilddir.txt to find _sysconfigdata for WASI#144535therohityadav wants to merge 1 commit intopython:mainfrom
therohityadav wants to merge 1 commit intopython:mainfrom
Conversation
therohityadav
requested review from
brettcannon,
emmatyping and
savannahostrowski
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
therohityadav
force-pushed
the
fix-wasi-build-144533
branch
from
5e55826 to
035c77e
Compare
therohityadav
force-pushed
the
fix-wasi-build-144533
branch
from
035c77e to
b64935a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pybuilddir.txtto find_sysconfigdatafor the WASI build script #144533Use
pybuilddir.txtto find_sysconfigdatafor the WASI build script.The previous implementation hardcoded the path pattern to
build/lib.wasi-wasm32-{python_version}. This change makes the script more robust by reading the exact build directory frompybuilddir.txtif it exists. It falls back to the hardcoded path if the file is missing to ensure backward compatibility during early build stages.