Skip to content

[3.14] gh-144330: Initialize classmethod and staticmethod in new#144498

Open
vstinner wants to merge 2 commits intopython:3.14from
vstinner:cm_new14
Open

[3.14] gh-144330: Initialize classmethod and staticmethod in new#144498
vstinner wants to merge 2 commits intopython:3.14from
vstinner:cm_new14

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 5, 2026

Initialize cm_callable and sm_callable to None in classmethod and staticmethod constructor.

Initialize cm_callable and sm_callable to None in classmethod and
staticmethod constructor.

Co-authored-by: Aniket Singh Yadav <singhyadavaniket43@gmail.com>
@vstinner
Copy link
Member Author

vstinner commented Feb 5, 2026

"Tests / Change detection / Create context from changed files" fails with:

+ git fetch origin +f27896c3191c5ffd85a62ac89a98f72fb14d9c61:remotes/origin/3.14 '--shallow-since=2026-02-05 12:04:04 +0100' --no-tags --prune --no-recurse-submodules
fatal: error processing shallow info: 4

I don't know why.

@StanFromIreland
Copy link
Member

StanFromIreland commented Feb 5, 2026

Maybe a GH outage, it sets github.event.pull_request.commits: 0 causing the error. I suggest trying to re-run in a bit.

@sergey-miryanov
Copy link
Contributor

I hope you don't mind if I ask :)
You did simpler version of 3.13 and 3.14 because #144469 changes user-observable behavior and that change considered as a feature?

@StanFromIreland
Copy link
Member

StanFromIreland commented Feb 5, 2026

I tried it again, still github.event.pull_request.commits is 0. Maybe the have some internal corruption, @webknjaz have you seen this before? I'll try updating the branch, that'll (theoretically) change the number and jog the data.

Edit: that worked, though I still wonder why it occurred in the first place... GitHub doing its thing 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants