gh-144540: Add _MAKE_HEAP_SAFE uop to eliminate unnecessary refcount operations in RETURN_VALUE and YIELD_VALUE#144414
Open
cocolato wants to merge 4 commits intopython:mainfrom
Open
Conversation
_RETURN_VALUE_HEAP_SAFE to avoid refcount operation_RETURN_VALUE_HEAP_SAFE to avoid refcount operation
Member
|
@cocolato in future can you avoid referencing the meta-issue in PRs. Make a new issue if you need to. I've done that for this PR already. |
Member
|
The removal of the "heap safe" check can be done for any return and for yields as well. |
_RETURN_VALUE_HEAP_SAFE to avoid refcount operation
Contributor
Author
Sorry about that, and thanks for letting me know! I've updated the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
RETURN_VALUEandYIELD_VALUEinto macro form with a new_MAKE_HEAP_SAFEmicro-op,so the tier2 optimizer can eliminate unnecessary
PyStackRef_MakeHeapSafe()callswhen the value is already heap-safe (owned or immortal).