Add next_anniversary functions to Date and DateTime#477
Open
StephenBrown2 wants to merge 3 commits intopython-pendulum:masterfrom
Open
Add next_anniversary functions to Date and DateTime#477StephenBrown2 wants to merge 3 commits intopython-pendulum:masterfrom
StephenBrown2 wants to merge 3 commits intopython-pendulum:masterfrom
Conversation
Author
|
MacOS having a bad day, apparently... :-/ |
StephenBrown2
force-pushed
the
add_next_anniversary
branch
from
d37c667 to
f453dc7
Compare
StephenBrown2
force-pushed
the
add_next_anniversary
branch
from
f453dc7 to
01053af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This adds
next_anniversaryto bothDateandDateTimeinstances, returning the next anniversary for a given instance, properly accounting for leap years by taking advantage of the.addfunction rather than simply comparing the month and day of an instance.