Add support for type definition#645
Merged
krassowski merged 6 commits intopython-lsp:developfrom Jul 4, 2025
Merged
Conversation
krassowski
reviewed
May 13, 2025
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
Makes sense to me, thank you!
Contributor
Author
|
Renamed plugin to *jedi_*type_definition, removed debug lines, fixed copyright lines. Oops... Force push to fix the ruff errors. |
Hoblovski
force-pushed
the
feat/type_definition
branch
from
eb5fc48 to
c516911
Compare
Hoblovski
force-pushed
the
feat/type_definition
branch
from
c516911 to
75f6234
Compare
Hoblovski
added a commit
to cloudwego/abcoder
that referenced
this pull request
May 15, 2025
Custom pylsp is based on [python-lsp-server](https://github.com/python-lsp/python-lsp-server), and plus the following pull requests: 1. semanticTokens/full: python-lsp/python-lsp-server#645 2. typeDefinition: python-lsp/python-lsp-server#533 Maybe also 3. implementation: python-lsp/python-lsp-server#644
Member
|
The linter is suggesting to move the line in config table so that they are neatly sorted: |
krassowski
approved these changes
May 28, 2025
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
This makes sense to me, but I will wait with merge to let other maintainers take a look too.
Hoblovski
added a commit
to cloudwego/abcoder
that referenced
this pull request
Jul 25, 2025
…n-lsp/python-lsp-server), and plus the following pull requests: 1. semanticTokens/full: python-lsp/python-lsp-server#645 2. typeDefinition: python-lsp/python-lsp-server#533 Maybe also 3. implementation: python-lsp/python-lsp-server#644
Hoblovski
added a commit
to cloudwego/abcoder
that referenced
this pull request
Jul 30, 2025
…n-lsp/python-lsp-server), and plus the following pull requests: 1. semanticTokens/full: python-lsp/python-lsp-server#645 2. typeDefinition: python-lsp/python-lsp-server#533 Maybe also 3. implementation: python-lsp/python-lsp-server#644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using jedi's
inferto support checking type definition.The same approach is used by jedi-language-server.
This PR, combined with smheidrich's Goto Implementation PR, should fix issue 97.
Also added some unit tests.