You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is a small update to @rumpelsepp's here: #579
It just points the python-lsp-jsonrpc dependency at the branch I have PR'd at python-lsp/python-lsp-jsonrpc#29, to demonstrate the tests pass.
@valrus@ccordoba12 Are there any existing tests to benchmark the python-lsp-server memory usage in the long run? The orjson library has some known "features" related to the memory usage and I really do not want to get OOM (Out of memory) errors or high memory usage after this pull request. I do not mean that this is guaranteed to get for python-lsp-server, but better to check to be sure.
@simon-liebehenschel I'm not aware of any tests covering memory usage, but I might take a stab at writing one. Can you provide any pointers to the issue(s) you're concerned about?
@simon-liebehenschel I'm not aware of any tests covering memory usage, but I might take a stab at writing one. Can you provide any pointers to the issue(s) you're concerned about?
But I do not know if it will have any impact on python-lsp-server because depends on a specific usage. If you think this PR is safe, let's try it and see if anyone notices any regression in memory usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a small update to @rumpelsepp's here: #579
It just points the
python-lsp-jsonrpcdependency at the branch I have PR'd at python-lsp/python-lsp-jsonrpc#29, to demonstrate the tests pass.