Dev series compare #162
Closed
Dev series compare #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@michaeltryby, do you want to update swmm-solver to 08772f this PR or in the release PR? I noticed there are a couple bug fixes since the ebbce3 commit that this branch references. |
Collaborator
Author
|
Hey @karosc! Release PR is fine. |
karosc
approved these changes
Feb 10, 2026
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a comparison test for series created while stride stepping during simulation run and post simulation using the output file. Results are not the same. This is likely due to a linear interpolation of report time relative to old and new step times that gets performed as output is written to the binary file.