Define LogPrior, LogPDF, LogPosterior and update set_target#897
Open
NicolaCourtier wants to merge 58 commits intodevelopfrom
Open
Define LogPrior, LogPDF, LogPosterior and update set_target#897NicolaCourtier wants to merge 58 commits intodevelopfrom
NicolaCourtier wants to merge 58 commits intodevelopfrom
Conversation
…eam/PyBOP into fix-parameter-assignment
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #897 +/- ##
===========================================
+ Coverage 89.41% 92.84% +3.42%
===========================================
Files 63 73 +10
Lines 4857 5674 +817
===========================================
+ Hits 4343 5268 +925
+ Misses 514 406 -108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds separate
LogPrior,LogPDFandLogPosteriorclasses to re-enable the comparison via plotting in themaximum_a_posteriori.ipynbexample and to clarify that samplers are only appropriate forLogPDF-type problems. Also updates theset_targetattribute of costs and problems.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).
Important checks:
Please confirm the following before marking the PR as ready for review:
$ pre-commit runor$ nox -s pre-commit(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)nox -s testsnox -s doctest