feat: added parameters named in parameters function#1086
Open
Gmin2 wants to merge 2 commits intoprocessing:mainfrom
Open
feat: added parameters named in parameters function#1086Gmin2 wants to merge 2 commits intoprocessing:mainfrom
Gmin2 wants to merge 2 commits intoprocessing:mainfrom
Conversation
Stefterv
requested changes
May 12, 2025
Collaborator
Stefterv
left a comment
There was a problem hiding this comment.
Hi @Gmin2 Thank you for your efforts on this!
We will need something that will figure out the parameters from core instead of a pre-defined list. In this case we would have to maintain the parameter definitions in the future and those might get out of sync over time.
| private static final Map<String, String[]> methodKnownParameterNames = new HashMap<>(); | ||
| static { | ||
| // PApplet drawing methods | ||
| methodKnownParameterNames.put("rect", new String[]{"x", "y", "width", "height"}); |
Collaborator
There was a problem hiding this comment.
This information should be gathered dynamically, not with a pre-defined list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parameters names in function signatures
Part of #1041
Some examples