Fix the computer contact injection when the corresponding value in the CSV file is empty

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Restored group selection in mappings
 - Fix special caracters malformed in translations
 - Fix error when displaying the additional information form
+- Fix the `computer contact` injection when the corresponding value in the CSV file is empty
 
 ## [2.15.3] - 2025-12-22
 

inc/backendcsv.class.php

@@ -98,27 +98,18 @@ public static function parseLine($fic, $data, $encoding = 1)
         $num = count($data);
 
         for ($c = 0; $c < $num; $c++) {
-            //If field is not the last, or if field is the last of the line and is not empty
-
-            if (
-                ($c < ($num - 1))
-                || (($c == ($num - 1))
-                && ($data[$num - 1] != PluginDatainjectionCommonInjectionLib::EMPTY_VALUE))
-            ) {
-                $tmp = trim($DB->escape($data[$c]));
-                switch ($encoding) {
-                    //If file is ISO8859-1 : encode the data in utf8
-                    case PluginDatainjectionBackend::ENCODING_ISO8859_1:
-                        $csv[0][] = $tmp === '' || $tmp === '0' ? Toolbox::encodeInUtf8($tmp) : $tmp;
-                        break;
-
-                    case PluginDatainjectionBackend::ENCODING_UFT8:
-                        $csv[0][] = $tmp;
-                        break;
-
-                    default: //PluginDatainjectionBackend :: ENCODING_AUTO :
-                        $csv[0][] = PluginDatainjectionBackend::toUTF8($tmp);
-                }
+            $tmp = trim($DB->escape($data[$c]));
+            switch ($encoding) {
+                case PluginDatainjectionBackend::ENCODING_ISO8859_1:
+                    $csv[0][] = $tmp === '' || $tmp === '0' ? Toolbox::encodeInUtf8($tmp) : $tmp;
+                    break;
+
+                case PluginDatainjectionBackend::ENCODING_UFT8:
+                    $csv[0][] = $tmp;
+                    break;
+
+                default:
+                    $csv[0][] = PluginDatainjectionBackend::toUTF8($tmp);
             }
         }
         return $csv;

inc/commoninjectionlib.class.php

@@ -680,12 +680,20 @@ private function getFieldValue(
                 break;
 
             case 'contact':
-                $id = $value != Dropdown::EMPTY_VALUE ? self::findContact($value, $this->entity) : Dropdown::EMPTY_VALUE;
+                if ($value === self::EMPTY_VALUE || $value == self::DROPDOWN_EMPTY_VALUE || $value === Dropdown::EMPTY_VALUE) {
+                    $id = self::DROPDOWN_EMPTY_VALUE;
+                } else {
+                    $id = self::findContact($value, $this->entity);
+                }
                 $this->setValueForItemtype($itemtype, $linkfield, $id);
                 break;
 
             case 'user':
-                $id = $value != Dropdown::EMPTY_VALUE ? self::findUser($value, $this->entity) : Dropdown::EMPTY_VALUE;
+                if ($value === self::EMPTY_VALUE || $value == self::DROPDOWN_EMPTY_VALUE || $value === Dropdown::EMPTY_VALUE) {
+                    $id = self::DROPDOWN_EMPTY_VALUE;
+                } else {
+                    $id = self::findUser($value, $this->entity);
+                }
                 $this->setValueForItemtype($itemtype, $linkfield, $id);
                 break;