Removed deprecation warnings surrounding 'named_scope'#1
Removed deprecation warnings surrounding 'named_scope'#1hoverlover wants to merge 5 commits intopluginaweek:masterfrom hoverlover:master
Conversation
|
Also, I am now requiring app/models/preference.rb. I'm not sure how this ever worked before, as I didn't see anyplace that this file was being required. Maybe the intention was to copy this file over to the projects app/models directory, but the README didn't state that. Anyway, it is now being required and works. |
|
Added an |
|
I really would like to move my project that is using this off of my fork. Any idea when/if you are going to pull this? I think it's a valuable addition. |
|
+1. Would also like to see the back of the class_inheritable_attribute warning. |
|
Any update on this pull request? I know we had a discussion a while ago about how you didn't know when you would be able to work on your open source projects due to you being so busy. I wouldn't mind helping you out if you want to make me a contributor. |
|
I reviewed the 3 outstanding pull requests. There is commonality among them all, so they should be simple to pull in. Like I said, I don't mind doing this for you if you want to add me as a collaborator on the project. |
|
+1 yo @pluginaweek, give some love to @hoverlover and make him a committer if you don't have to time to accept pull requests anymore. |
|
+1 |
…s rubocopisms
I changed the calls to the Rails 3 deprecated method
named_scopein favor ofscope. I tried running the tests but I'm getting the following error:Since this is just a simple method name change for a method that is already tested in the Rails source, I don't think there should be any failures from my changes. If you would like to help me get the tests running that would be great too!