Use try catch instead of isempty() to check if variable exists#326
Open
sameehj wants to merge 1 commit intoplotly:masterfrom
Open
Use try catch instead of isempty() to check if variable exists#326sameehj wants to merge 1 commit intoplotly:masterfrom
sameehj wants to merge 1 commit intoplotly:masterfrom
Conversation
If DisplayName doesn't exist for some reason we might get the following error [0]. Simply use try catch to store the name. [0] - Unrecongnized field name "DisplayName". Signed-off-by: Sameeh Jubran <sameehj.@gmail.com>
harshpurwar
approved these changes
Aug 9, 2021
Contributor
harshpurwar
left a comment
harshpurwar
left a comment
There was a problem hiding this comment.
Good for me. I think a lot more files will need similar changes. All of us need to keep this in mind and change it when we come across such an if-else statement to try-catch.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If DisplayName doesn't exist for some reason we might get the following
error [0].
Simply use try catch to store the name.
[0] - Unrecongnized field name "DisplayName".
Signed-off-by: Sameeh Jubran sameehj.@gmail.com