Fix: Don't modify global warnings.formatwarning#5482
Open
RamiNoodle733 wants to merge 1 commit intoplotly:mainfrom
Open
Fix: Don't modify global warnings.formatwarning#5482RamiNoodle733 wants to merge 1 commit intoplotly:mainfrom
RamiNoodle733 wants to merge 1 commit intoplotly:mainfrom
Conversation
Remove global modification of warnings.formatwarning from: - plotly/tools.py - plotly/matplotlylib/renderer.py The previous implementation was setting warnings.formatwarning to a custom function at module import time, which changed the warning format for all warnings in the Python process, not just plotly's warnings. This fix ensures plotly doesn't interfere with Python's default warning format or any custom format set by the user. Added test to verify warnings.formatwarning is not modified by plotly imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #5472.
Problem
The codebase was modifying the global
warnings.formatwarningfunction in two places:packages/python/plotly/plotly/io/_renderers/renderer.pypackages/python/plotly/plotly/io/_renderers/tools.pyModifying global warning state is bad practice as it can affect user code and other libraries in unexpected ways.
Solution
This PR removes the global
warnings.formatwarningmodification from both files. Users who want custom warning formatting can do so in their own code without plotly interfering with global state.Fixes #5472