Use upstream d3-sankey and d3-sankey-circular dependencies#7696
Draft
adamreeve wants to merge 2 commits intoplotly:masterfrom
Draft
Use upstream d3-sankey and d3-sankey-circular dependencies#7696adamreeve wants to merge 2 commits intoplotly:masterfrom
adamreeve wants to merge 2 commits intoplotly:masterfrom
Conversation
adamreeve
commented
Jan 22, 2026
Contributor
Author
There was a problem hiding this comment.
This looks like a regression that might block being able to use the upstream d3-sankey directly for now.
Contributor
There was a problem hiding this comment.
Any idea what might be causing the issue?
Contributor
Author
There was a problem hiding this comment.
No, I'm not that familiar with the internals of the library. I can look into this but it might take a while as I don't have a lot of time to spend on this at the moment.
Contributor
There was a problem hiding this comment.
No rush. If/when this PR is ready for review, let us know and we'll take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7689