fix error on clearing crosstalk selection#2098
Open
casperhart wants to merge 1 commit intoplotly:masterfrom
Open
fix error on clearing crosstalk selection#2098casperhart wants to merge 1 commit intoplotly:masterfrom
casperhart wants to merge 1 commit intoplotly:masterfrom
Conversation
237411e to
393c960
Compare
Collaborator
|
Thanks, can you please provide an example that demonstrates the fix? |
393c960 to
cd63424
Compare
Contributor
Author
|
@cpsievert to reproduce, run the following in R: library(crosstalk)
library(plotly)
library(DT)
data(iris)
shared_iris <- SharedData$new(iris)
a <- plot_ly(shared_iris, x = ~Sepal.Length, y = ~Sepal.Width) %>%
add_markers() %>%
highlight(on = "plotly_click", dynamic = TRUE)
b <- datatable(shared_iris)
bscols(
list(
filter_checkbox("species", "Species", shared_iris, ~Species)
),
a, b
)Then select some points in the plotly visual, open up the browser console and run the following: const handleId = Object.keys(__crosstalk_groups)[1]
const myHandle = new crosstalk.SelectionHandle(handleId)
myHandle.clear()In the main branch code, this throws an error and the selection is not cleared. Using the version in this PR, no error is thrown and the crosstalk selection is successfully cleared. |
|
@cpsievert would it be possible to have a look at merging this fix? I ran into this issue today. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linking plots using {crosstalk}, running

selectionHandle.clear()from another (non-plotly) visual causes the following error to appear in the console and the selection in the plotly visual is not cleared:This is because
selectionHandle.clear()event passes anundefinedvalue, which plotly isn't dealing with properly.This PR fixes this issue.