You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
should we maybe add this to Plotly.NET.Interactive for now (also making Plotly.NET.Interactive dependent on Plotly.NET.CSharp in the process), to have all in the same place? When this works for F# as well, we can get rid of the Interactive package alltogether and just add the .dib file to the indivisual packages.
It doesn't work if the dib file is written in F#, and it also doesn't work when F#/C# dib file is invoked from F# context. So only C# from C# works for now.
Yes, you can make Interactive dependent on Plotly.NET.CSharp instead of Plotly.NET. Both work. I personally think, that making Plotly.NET.CSharp interactive on its own is a bit better, because a bit more intuitive and less deps for interactive, but yeah, up to you.
When this works for F# as well, we can get rid of the Interactive package alltogether and just add the .dib file to the indivisual packages.
Actually, if we don't care about the size of the package, we could as well just bake everything (C#, F#, bindings) into one package (again, as soon as they fix that bug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we can do this