Apply default values in Terraform and CloudRun Deployment plugin#6516
Open
rawadhossain wants to merge 1 commit intopipe-cd:masterfrom
Open
Apply default values in Terraform and CloudRun Deployment plugin#6516rawadhossain wants to merge 1 commit intopipe-cd:masterfrom
rawadhossain wants to merge 1 commit intopipe-cd:masterfrom
Conversation
Signed-off-by: Rawad Hossain <rawad.hossain00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implements setting default values in the
CloudRunandTerraform deploymentplugins by addingUnmarshalJSONmethods that calldefaults.Set().Why we need it:
ServiceManifestFilewas documented to default toservice.yaml, but the default was never applied.DriftDetectionEnabledhad a defaulttruetag but the value was never set during unmarshaling.Part of Issue #6174
Does this PR introduce a user-facing change?:
serviceManifestFilewill now correctly default toservice.yamldriftDetectionEnabledwill now correctly default totrue